Skip to content

Ban loop aliases in table definitions#25059

Merged
alesapin merged 2 commits intomasterfrom
fix_loop_aliases
Jun 8, 2021
Merged

Ban loop aliases in table definitions#25059
alesapin merged 2 commits intomasterfrom
fix_loop_aliases

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Jun 7, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug which allows creating tables with columns referencing themselves like a UInt32 ALIAS a + 1 or b UInt32 MATERIALIZED b. Fixes #24910, #24292.

I'm not 100% percent sure that this one is the right place for fix.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Jun 7, 2021
@CurtizJ CurtizJ self-assigned this Jun 8, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jun 8, 2021

Ok, no related failures.

@alesapin alesapin merged commit 185fb83 into master Jun 8, 2021
@alesapin alesapin deleted the fix_loop_aliases branch June 8, 2021 20:36
alesapin added a commit that referenced this pull request Jun 10, 2021
Backport #25059 to 21.6: Ban loop aliases in table definitions
vitlibar pushed a commit that referenced this pull request Jun 22, 2021
Backport #25059 to 21.5: Ban loop aliases in table definitions
vitlibar pushed a commit that referenced this pull request Jun 22, 2021
Backport #25059 to 21.3: Ban loop aliases in table definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Self-referencing MATERIALIZED is not forbidden

3 participants