Distinguish KILL MUTATION for different tables.#25025
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Jun 8, 2021
Merged
Distinguish KILL MUTATION for different tables.#25025alexey-milovidov merged 4 commits intoClickHouse:masterfrom
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
This was referenced Jun 6, 2021
tavplubix
approved these changes
Jun 7, 2021
This will avoid bugs, like comparing StorageID w/o operator== via cast to bool.
Before this patch KILL MUTATION marks mutation as canceled just by name (and part numbers) so if you have multiple tables with the same part name, then killing mutation for one table, will mark it as killed for another too. Fix this by comparing StorageID too (it is better to use StorageID over database/table to avoid ambiguity by using UUIDs for comparing). Here is a failure of the 01414_freeze_does_not_prevent_alters on CI [1]. [1]: https://clickhouse-test-reports.s3.yandex.net/24069/9fb69dcf98c71a939d200cad3c8491bf43a44622/functional_stateless_tests_(ubsan).html#fail1
azat
force-pushed
the
parallel-kill-mutation
branch
from
dd9954d to
fc46005
Compare
This was referenced Jun 8, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 8, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 8, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Jun 12, 2021
Backport #25025 to 21.6: Distinguish KILL MUTATION for different tables.
alexey-milovidov
added a commit
that referenced
this pull request
Jun 12, 2021
Backport #25025 to 21.5: Distinguish KILL MUTATION for different tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Distinguish KILL MUTATION for different tables (fixes unexpected
Cancelled mutating partserror)Detailed description / Documentation draft:
Before this patch KILL MUTATION marks mutation as canceled just by name
(and part numbers) so if you have multiple tables with the same part
name, then killing mutation for one table, will mark it as killed for
another too.
Fix this by comparing StorageID too (it is better to use StorageID over
database/table to avoid ambiguity by using UUIDs for comparing).
Here is a failure of the 01414_freeze_does_not_prevent_alters on CI 1.
Refs: #24809