Trying to fix 'Tagging already tagged part'#24961
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
alesapin
commented
Jun 4, 2021
| { | ||
| /// If our entry produce part which is already covered by | ||
| /// some other entry which is currently executing, then we can postpone this entry. | ||
| if (entry.type == LogEntry::MERGE_PARTS |
Member
Author
There was a problem hiding this comment.
I just don't understand why this if exists. If we already executing some entry that will produce new_part_name (or part covering it) then we should postpone anything that will produce the same or covered part (even DROP_RANGE, REPLACE_RANGE and so on).
Member
Author
|
No related failures. |
This was referenced Jun 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 7, 2021
alesapin
added a commit
that referenced
this pull request
Jun 11, 2021
Backport #24961 to 21.6: Trying to fix 'Tagging already tagged part'
alexey-milovidov
added a commit
that referenced
this pull request
Jun 12, 2021
Backport #24961 to 21.5: Trying to fix 'Tagging already tagged part'
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 21, 2021
vitlibar
pushed a commit
that referenced
this pull request
Jun 22, 2021
Backport #24961 to 21.3: Trying to fix 'Tagging already tagged part'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix extremely rare error
Tagging already tagged partin replication queue during concurrentalter move/replace partition. Possibly fixes #22142.Example error: https://clickhouse-test-reports.s3.yandex.net/24775/bc763981fc961a3460df1a042e08991a3434ce89/stress_test_(undefined).html#fail1