Skip to content

Fix mutation wait on mutation kill#24809

Merged
alesapin merged 1 commit intomasterfrom
fix_kill_mutation_wait
Jun 1, 2021
Merged

Fix mutation wait on mutation kill#24809
alesapin merged 1 commit intomasterfrom
fix_kill_mutation_wait

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented May 31, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug when exception Mutation was killed can be thrown to the client on mutation wait when mutation not loaded into memory yet.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label May 31, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented May 31, 2021

Fix flaky: 00652_replicated_mutations_zookeeper and 00834_kill_mutation.

@tavplubix tavplubix self-assigned this May 31, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented May 31, 2021

01414_freeze_does_not_prevent_alters Also have a bug with non replicated merge tree mutations....

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jun 1, 2021

2021.05.31 20:11:32.074243 [ 903528 ] {} <Error> test_27.dst_5 (ReplicatedMergeTreeQueue): Code: 49, e.displayText() = DB::Exception: Part 1_37_40_2 intersects next part 1_38_43_2. It is a bug., Stack trace (when copying this message, always include the lines below):

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jun 1, 2021

Ok, this fix is useful.

@alesapin alesapin merged commit b7c4f7d into master Jun 1, 2021
@alesapin alesapin deleted the fix_kill_mutation_wait branch June 1, 2021 07:37
This was referenced Jun 1, 2021
Merged
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Jun 1, 2021
Backport #24809 to 21.3: Fix mutation wait on mutation kill
d6bce57
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 1, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Jun 1, 2021
Backport #24809 to 21.6: Fix mutation wait on mutation kill
e43ccd5
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 1, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Jun 1, 2021
Backport #24809 to 20.8: Fix mutation wait on mutation kill
0bc07b4
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 1, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Jun 1, 2021
Backport #24809 to 21.4: Fix mutation wait on mutation kill
d0919dd
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 1, 2021
Closed
robot-clickhouse pushed a commit that referenced this pull request Jun 1, 2021
Backport #24809 to 21.5: Fix mutation wait on mutation kill
45f0063
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 1, 2021
Merged
alesapin added a commit that referenced this pull request Jun 2, 2021
@alesapin
Merge pull request #24850 from ClickHouse/backport/21.3/24809
17b9d28 
Backport #24809 to 21.3: Fix mutation wait on mutation kill
alesapin added a commit that referenced this pull request Jun 2, 2021
@alesapin
Merge pull request #24851 from ClickHouse/backport/21.6/24809
f88a79f 
Backport #24809 to 21.6: Fix mutation wait on mutation kill
alexey-milovidov added a commit that referenced this pull request Jun 4, 2021
@alexey-milovidov
Merge pull request #24854 from ClickHouse/backport/21.5/24809
0e82d2e 
Backport #24809 to 21.5: Fix mutation wait on mutation kill
alesapin added a commit that referenced this pull request Jun 4, 2021
@alesapin
Merge pull request #24852 from ClickHouse/backport/20.8/24809
0b92812 
Backport #24809 to 20.8: Fix mutation wait on mutation kill
@azat azat mentioned this pull request Jun 6, 2021
Merged
@azat
Copy link
Copy Markdown
Member

azat commented Jun 6, 2021

01414_freeze_does_not_prevent_alters Also have a bug with non replicated merge tree mutations....

@alesapin #25025 should fix this

@azat azat mentioned this pull request Sep 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees

@tavplubix tavplubix

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alesapin @azat @tavplubix @robot-clickhouse