Merged
Conversation
robot-clickhouse
added
doc-alert
pr-feature
Member
|
Please, don't forget about adding tests. |
danlark1
reviewed
Jun 5, 2021
|
|
||
| auto new_subquery = std::make_shared<ASTSubquery>(); | ||
| new_subquery->children.push_back(select_with_union_query); | ||
| function->children[0]->children.pop_back(); |
Contributor
There was a problem hiding this comment.
Why not just std::move to the last?
kssenii
force-pushed
the
subquery-operators
branch
from
f6163bf to
f66e846
Compare
kssenii
approved these changes
Aug 15, 2021
Contributor
|
Internal documentation ticket: DOCSUP-13264 |
24 tasks
tavplubix
reviewed
Nov 28, 2022
Comment on lines
+1003
to
+1007
| else if (!this->isEqualTo(column, row_num)) | ||
| { | ||
| is_null = true; | ||
| } | ||
| return false; |
Member
There was a problem hiding this comment.
So it returns false when the value was actually changed to NULL, why? @kssenii, do you remember?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for INTERSECT, EXCEPT, ANY, ALL operators.