Skip to content

Remove endless wait from ZooKeeper client#24721

Merged
alesapin merged 1 commit intomasterfrom
dont_wait_forever_in_zookeeper
May 30, 2021
Merged

Remove endless wait from ZooKeeper client#24721
alesapin merged 1 commit intomasterfrom
dont_wait_forever_in_zookeeper

Conversation

@alesapin
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug which can lead to ZooKeeper client hung inside clickhouse-server.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label May 28, 2021
@akuzm akuzm self-assigned this May 28, 2021
@alesapin
Copy link
Copy Markdown
Member Author

ubsan: Part -1_0_76_4_172 intersects next part -1_0_77_4_136. It is a bug., Stack trace (when copying this message, always include the lines below): Known error after checks hardening.
thread: 01289_min_execution_speed_not_too_early -- unrelated to changes
db replicated: 00910_zookeeper_test_alter_compression_codecs_long -- known flaky.

@alesapin
Copy link
Copy Markdown
Member Author

performance unrelated

@alesapin alesapin merged commit 41328a4 into master May 30, 2021
@alesapin alesapin deleted the dont_wait_forever_in_zookeeper branch May 30, 2021 13:12
alesapin added a commit that referenced this pull request May 31, 2021
Backport #24721 to 21.5: Remove endless `wait` from ZooKeeper client
alesapin added a commit that referenced this pull request May 31, 2021
Backport #24721 to 21.3: Remove endless `wait` from ZooKeeper client
alesapin added a commit that referenced this pull request May 31, 2021
Backport #24721 to 21.4: Remove endless `wait` from ZooKeeper client
alesapin added a commit that referenced this pull request May 31, 2021
alesapin added a commit that referenced this pull request May 31, 2021
…24721

Revert "Backport #24721 to 21.4: Remove endless `wait` from ZooKeeper client"
alesapin added a commit that referenced this pull request May 31, 2021
alesapin added a commit that referenced this pull request May 31, 2021
…24721

Revert "Backport #24721 to 21.5: Remove endless `wait` from ZooKeeper client"
alesapin added a commit that referenced this pull request May 31, 2021
alesapin added a commit that referenced this pull request May 31, 2021
…24721

Revert "Backport #24721 to 21.3: Remove endless `wait` from ZooKeeper client"
@alexey-milovidov
Copy link
Copy Markdown
Member

It was incorrect - reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants