Avoid hiding errors like Limit for rows or bytes to read exceeded for scalar subqueries#24545
Merged
kitaisreal merged 4 commits intoClickHouse:masterfrom May 28, 2021
nvartolomei:nv/scalar-subquery-exception
Merged
Avoid hiding errors like Limit for rows or bytes to read exceeded for scalar subqueries#24545kitaisreal merged 4 commits intoClickHouse:masterfrom nvartolomei:nv/scalar-subquery-exception
Limit for rows or bytes to read exceeded for scalar subqueries#24545kitaisreal merged 4 commits intoClickHouse:masterfrom
nvartolomei:nv/scalar-subquery-exception
Conversation
robot-clickhouse
added
the
pr-bugfix
kitaisreal
approved these changes
May 26, 2021
Contributor
Author
|
@kitaisreal should i fix the style check and re-trigger CI or is there a more efficient way?) |
Contributor
|
@nvartolomei no need for changes from your side, need to investigate why synchronization check failed. |
kitaisreal
approved these changes
May 28, 2021
This was referenced May 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 30, 2021
…bytes to read exceeded` for scalar subqueries
robot-clickhouse
pushed a commit
that referenced
this pull request
May 31, 2021
…bytes to read exceeded` for scalar subqueries
robot-clickhouse
pushed a commit
that referenced
this pull request
May 31, 2021
…bytes to read exceeded` for scalar subqueries
robot-clickhouse
pushed a commit
that referenced
this pull request
May 31, 2021
…bytes to read exceeded` for scalar subqueries
kitaisreal
added a commit
that referenced
this pull request
May 31, 2021
Backport #24545 to 21.3: Avoid hiding errors like `Limit for rows or bytes to read exceeded` for scalar subqueries
kitaisreal
added a commit
that referenced
this pull request
May 31, 2021
Backport #24545 to 21.5: Avoid hiding errors like `Limit for rows or bytes to read exceeded` for scalar subqueries
kitaisreal
added a commit
that referenced
this pull request
Jun 1, 2021
Backport #24545 to 21.4: Avoid hiding errors like `Limit for rows or bytes to read exceeded` for scalar subqueries
robot-clickhouse
added
pr-improvement
alexey-milovidov
added a commit
that referenced
this pull request
Jun 1, 2021
Backport #24545 to 21.6: Avoid hiding errors like `Limit for rows or bytes to read exceeded` for scalar subqueries
Member
|
It is not a bugfix. Improvement in exception message. Was not required to backport it anywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid hiding errors like
Limit for rows or bytes to read exceededfor scalar subqueries.Currently, it throws
DB::Exception: Scalar subquery returned more than one rowwhen user defined limit is hit which doesn't make sense.