Skip to content

Make get/check/read/list requests always read in Keeper#24533

Merged
alesapin merged 1 commit intomasterfrom
watch_requests_read
May 27, 2021
Merged

Make get/check/read/list requests always read in Keeper#24533
alesapin merged 1 commit intomasterfrom
watch_requests_read

Conversation

@alesapin
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

We don't support sessions move between quorum participants, so these requests must be always read. Integration tests for watches will check errors if any.

@alesapin alesapin added the jepsen-test Need to test this PR with jepsen tests label May 26, 2021
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 26, 2021
@tavplubix tavplubix self-assigned this May 26, 2021
@alesapin
Copy link
Copy Markdown
Member Author

Very strange performance report....

@alesapin
Copy link
Copy Markdown
Member Author

No related failures.

@alesapin alesapin merged commit 75dad2c into master May 27, 2021
@alesapin alesapin deleted the watch_requests_read branch May 27, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jepsen-test Need to test this PR with jepsen tests pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants