Try to fix deadlock in ThreadPool#24457
Merged
nikitamikhaylov merged 4 commits intoClickHouse:masterfrom May 26, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
nikitamikhaylov
commented
May 24, 2021
src/Common/ThreadPool.cpp
Outdated
Member
Author
There was a problem hiding this comment.
The bug how I think was here. In case of exception from threads.emplace_front() we don't signal on this event, but a task was added to the queue.
Member
Author
|
@Mergifyio update |
Contributor
|
Command
|
KochetovNicolai
approved these changes
May 25, 2021
Member
KochetovNicolai
left a comment
KochetovNicolai
left a comment
There was a problem hiding this comment.
Ok to me.
Maybe you can add some more comments to avoid such a case in future?
nikitamikhaylov
force-pushed
the
thread-pool-deadlock
branch
from
1c684ab to
ba6595c
Compare
Member
Author
|
@Mergifyio update |
Contributor
|
Command
|
This was referenced May 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 27, 2021
This was referenced May 27, 2021
nikitamikhaylov
added a commit
that referenced
this pull request
May 28, 2021
Backport #24457 to 21.6: Try to fix deadlock in ThreadPool
nikitamikhaylov
added a commit
that referenced
this pull request
May 28, 2021
Backport #24457 to 21.5: Try to fix deadlock in ThreadPool
nikitamikhaylov
added a commit
that referenced
this pull request
May 28, 2021
Backport #24457 to 21.4: Try to fix deadlock in ThreadPool
robot-clickhouse
pushed a commit
that referenced
this pull request
May 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 28, 2021
nikitamikhaylov
added a commit
that referenced
this pull request
May 31, 2021
Backport #24457 to 21.3: Try to fix deadlock in ThreadPool
nikitamikhaylov
added a commit
that referenced
this pull request
May 31, 2021
Backport #24457 to 20.8: Try to fix deadlock in ThreadPool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed the behavior when query
SYSTEM RESTART REPLICAorSYSTEM SYNC REPLICAis being processed infinitely. This was detected on server with extremely little amount of RAM.