Skip to content

Add ACL system to Keeper#24448

Merged
alesapin merged 18 commits intomasterfrom
keeper_auth
May 30, 2021
Merged

Add ACL system to Keeper#24448
alesapin merged 18 commits intomasterfrom
keeper_auth

Conversation

@alesapin
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now clickhouse-keeper supports ZooKeeper-like digest ACLs.

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels May 24, 2021

using WatchCallback = std::function<void(const WatchResponse &)>;

struct SetACLRequest : virtual Request
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently unused, and I'm not sure, that I'm going to implement them.

@alesapin
Copy link
Copy Markdown
Member Author

???

@alesapin
Copy link
Copy Markdown
Member Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 24, 2021

Command update: success

Branch has been successfully updated

@alesapin
Copy link
Copy Markdown
Member Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 25, 2021

Command update: success

Branch has been successfully updated

@alesapin
Copy link
Copy Markdown
Member Author

Functional stateless tests (release, DatabaseReplicated) — fail: 20, passed: 1651, skipped: 45 not related to changes.

@alesapin
Copy link
Copy Markdown
Member Author

No related failures, but let's check one more time.

@alesapin
Copy link
Copy Markdown
Member Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 26, 2021

Command update: success

Branch has been successfully updated

@alesapin
Copy link
Copy Markdown
Member Author

One more time and merge.

@alesapin
Copy link
Copy Markdown
Member Author

Oh, no. Need some improvements.

@alesapin
Copy link
Copy Markdown
Member Author

No related failures, I'll merge.

@alesapin alesapin merged commit 07afb42 into master May 30, 2021
@alesapin alesapin deleted the keeper_auth branch May 30, 2021 13:17
@gyuton
Copy link
Copy Markdown
Contributor

gyuton commented Aug 31, 2021

Internal documentation ticket: DOCSUP-13992.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants