Skip to content

Consider last CRLF as part of boundary#24399

Merged
abyss7 merged 4 commits intoClickHouse:masterfrom
abyss7:issue-23905
May 28, 2021
Merged

Consider last CRLF as part of boundary#24399
abyss7 merged 4 commits intoClickHouse:masterfrom
abyss7:issue-23905

Conversation

@abyss7
Copy link
Copy Markdown
Contributor

@abyss7 abyss7 commented May 21, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
In "multipart/form-data" message consider the CRLF preceding a boundary as part of it. Fixes #23905

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label May 21, 2021
@alexey-milovidov alexey-milovidov self-assigned this May 24, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 27, 2021

Command update: success

Branch has been successfully updated

@abyss7
Copy link
Copy Markdown
Contributor Author

abyss7 commented May 28, 2021

Failed test are just flaky.

@abyss7 abyss7 merged commit ce2a809 into ClickHouse:master May 28, 2021
@abyss7 abyss7 deleted the issue-23905 branch May 28, 2021 11:59
alexey-milovidov added a commit that referenced this pull request May 31, 2021
Backport #24399 to 21.3: Consider last CRLF as part of boundary
alexey-milovidov added a commit that referenced this pull request May 31, 2021
Backport #24399 to 21.4: Consider last CRLF as part of boundary
alexey-milovidov added a commit that referenced this pull request May 31, 2021
Backport #24399 to 21.5: Consider last CRLF as part of boundary
alexey-milovidov added a commit that referenced this pull request May 31, 2021
Backport #24399 to 21.6: Consider last CRLF as part of boundary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Cannot read all data" exception when sending External Data in RowBinary format

3 participants