Skip to content

Adding experimental 01900_alter_race_condition_stress.sh stateless test#24132

Closed
vzakaznikov wants to merge 11 commits intoClickHouse:masterfrom
vzakaznikov:rbac_alter_fail_bash_test
Closed

Adding experimental 01900_alter_race_condition_stress.sh stateless test#24132
vzakaznikov wants to merge 11 commits intoClickHouse:masterfrom
vzakaznikov:rbac_alter_fail_bash_test

Conversation

@vzakaznikov
Copy link
Copy Markdown
Contributor

@vzakaznikov vzakaznikov commented May 14, 2021 •
edited by alexey-milovidov
Loading

Changelog category (leave one):

  • Not for changelog

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label May 14, 2021
@vzakaznikov vzakaznikov mentioned this pull request May 14, 2021
Closed
@qoega
Copy link
Copy Markdown
Member

qoega commented May 17, 2021

fuzzer
#24184

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented May 31, 2021

@Mergifyio update

@robot-clickhouse robot-clickhouse added pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-build Pull request with build/testing/packaging improvement labels May 31, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 31, 2021

Command update: success

Branch has been successfully updated

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jun 12, 2021

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2021

Command update: success

Branch has been successfully updated

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 9, 2021

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 9, 2021

Command update: success

Branch has been successfully updated

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 9, 2021

@vzakaznikov There is no description what this test is going to test and it is very difficult to read. Could you please explain?

@vzakaznikov
Copy link
Copy Markdown
Contributor Author

vzakaznikov commented Jul 10, 2021

@vzakaznikov There is no description what this test is going to test and it is very difficult to read. Could you please explain?

This test was an attempt to reproduce an issue when we tried to alter column from string type to float with some rows having empty strings which caused intermittent test fails. When we first ran this test with thread fuzzer we found a race condition in RBAC. I don't think we need to add this test to stateless as is and I propose to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vzakaznikov @qoega @alexey-milovidov @robot-clickhouse