Date time timezone fix#24129
Merged
kitaisreal merged 5 commits intoClickHouse:masterfrom Jun 29, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
kitaisreal
force-pushed
the
date-time-timezone-fix
branch
from
87b1700 to
f3755c9
Compare
src/DataTypes/getLeastSupertype.cpp
Outdated
Member
There was a problem hiding this comment.
We can simply return t, no need to construct a new object.
src/DataTypes/getLeastSupertype.cpp
Outdated
Member
There was a problem hiding this comment.
Then we can avoid typeid_cast :)
src/DataTypes/getLeastSupertype.cpp
Outdated
Member
|
Only a few changes required... |
kitaisreal
force-pushed
the
date-time-timezone-fix
branch
from
a3f0741 to
61b1163
Compare
kitaisreal
force-pushed
the
date-time-timezone-fix
branch
from
d4c1047 to
bd7bc6b
Compare
kitaisreal
force-pushed
the
date-time-timezone-fix
branch
from
bd7bc6b to
764380f
Compare
This was referenced Jun 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 29, 2021
kitaisreal
added a commit
that referenced
this pull request
Jun 30, 2021
Backport #24129 to 21.7: Date time timezone fix
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 30, 2021
kitaisreal
added a commit
that referenced
this pull request
Jul 1, 2021
Backport #24129 to 21.3: Date time timezone fix
kitaisreal
added a commit
that referenced
this pull request
Jul 1, 2021
Backport #24129 to 21.6: Date time timezone fix
kitaisreal
added a commit
that referenced
this pull request
Jul 1, 2021
Backport #24129 to 21.5: Date time timezone fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
CASTfromDatetoDateTime(orDateTime64) was not using the timezone of theDateTimetype. It can also affect the comparison betweenDateandDateTime. Inference of the common type forDateandDateTimealso was not using the corresponding timezone. It affected the results of functionifand array construction. Closes #24128.