Skip to content

Set readonly mode if restarting thread failed to activate replica#24122

Merged
alesapin merged 4 commits intomasterfrom
fix_table_startup
May 16, 2021
Merged

Set readonly mode if restarting thread failed to activate replica#24122
alesapin merged 4 commits intomasterfrom
fix_table_startup

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented May 14, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix a rare bug that could lead to a partially initialized table that can serve write requests (insert/alter/so on). Now such tables will be in readonly mode.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label May 14, 2021
@alesapin
Copy link
Copy Markdown
Member Author

test_polymorphic_parts/test.py::test_in_memory_deduplication also broken tests. Need to fix them.

@alesapin
Copy link
Copy Markdown
Member Author

SQLancer: Cannot convert column less(c1, c0) because it is non constant in source stream but must be constant in result
known failure

@alesapin alesapin merged commit 29726b5 into master May 16, 2021
@alesapin alesapin deleted the fix_table_startup branch May 16, 2021 13:45
robot-clickhouse pushed a commit that referenced this pull request May 16, 2021
robot-clickhouse pushed a commit that referenced this pull request May 16, 2021
robot-clickhouse pushed a commit that referenced this pull request May 17, 2021
alesapin added a commit that referenced this pull request May 19, 2021
Backport #24122 to 21.3: Set readonly mode if restarting thread failed to activate replica
alesapin added a commit that referenced this pull request May 19, 2021
Backport #24122 to 21.4: Set readonly mode if restarting thread failed to activate replica
alesapin added a commit that referenced this pull request May 23, 2021
Backport #24122 to 21.5: Set readonly mode if restarting thread failed to activate replica
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants