Skip to content

Fix bug for explain pipeline#24116

Merged
kitaisreal merged 2 commits intoClickHouse:masterfrom
hexiaoting:dev_explain
May 14, 2021
Merged

Fix bug for explain pipeline#24116
kitaisreal merged 2 commits intoClickHouse:masterfrom
hexiaoting:dev_explain

Conversation

@hexiaoting
Copy link
Copy Markdown
Contributor

@hexiaoting hexiaoting commented May 14, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Bug: explain pipeline withselect xxx finalshows wrong pipeline:

dell123 :) explain pipeline select z from prewhere_move_select_final final;

┌─explain───────────────────────────────┐
│ (Expression)                          │
│ ExpressionTransform × 16              │
│   (SettingQuotaAndLimits)             │
│     (Expression)                      │
│     ExpressionTransform × 16          │
│       (MergingFinal)                  │
│       AddingSelector × 2              │
│         ExpressionTransform × 2       │
│           MergeTree × 2 0 → 1         │
│             AddingSelector × 2        │
│               (Expression)            │
│               ExpressionTransform × 2 │
│                 (ReadFromMergeTree)   │
│                 MergeTree × 2 0 → 1   │
└───────────────────────────────────────┘

After fix:

dell123 :) select version()

┌─version()─┐
│ 21.6.1.1  │
└───────────┘

dell123 :) explain pipeline select z from prewhere_move_select_final final;

┌─explain─────────────────────────────┐
│ (Expression)                        │
│ ExpressionTransform × 16            │
│   (SettingQuotaAndLimits)           │
│     (Expression)                    │
│     ExpressionTransform × 16        │
│       (MergingFinal)                │
│       ReplacingSorted × 16 2 → 1    │
│         Copy × 2 1 → 16             │
│           AddingSelector × 2        │
│             (Expression)            │
│             ExpressionTransform × 2 │
│               (ReadFromMergeTree)   │
│               MergeTree × 2 0 → 1   │
└─────────────────────────────────────┘

Detailed description / Documentation draft:

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label May 14, 2021
@qoega
Copy link
Copy Markdown
Member

qoega commented May 14, 2021

You can add test for explain final.

@kitaisreal kitaisreal self-assigned this May 14, 2021
@kitaisreal kitaisreal merged commit e785029 into ClickHouse:master May 14, 2021
This was referenced May 14, 2021
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request May 15, 2021
Backport #24116 to 21.3: Fix bug for explain pipeline
0d75387
@robot-clickhouse robot-clickhouse mentioned this pull request May 15, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request May 15, 2021
Backport #24116 to 21.4: Fix bug for explain pipeline
e87d180
@robot-clickhouse robot-clickhouse mentioned this pull request May 15, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request May 15, 2021
Backport #24116 to 21.5: Fix bug for explain pipeline
37a5d74
@robot-clickhouse robot-clickhouse mentioned this pull request May 15, 2021
Merged
@hexiaoting hexiaoting deleted the dev_explain branch May 17, 2021 03:45
kitaisreal added a commit that referenced this pull request May 17, 2021
@kitaisreal
Merge pull request #24140 from ClickHouse/backport/21.3/24116
30c04f1 
Backport #24116 to 21.3: Fix bug for explain pipeline
kitaisreal added a commit that referenced this pull request May 17, 2021
@kitaisreal
Merge pull request #24141 from ClickHouse/backport/21.4/24116
fa9a8d9 
Backport #24116 to 21.4: Fix bug for explain pipeline
kitaisreal added a commit that referenced this pull request May 17, 2021
@kitaisreal
Merge pull request #24142 from ClickHouse/backport/21.5/24116
f88d812 
Backport #24116 to 21.5: Fix bug for explain pipeline
@robot-clickhouse robot-clickhouse mentioned this pull request May 28, 2021
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request May 28, 2021
Closed
robot-clickhouse pushed a commit that referenced this pull request May 28, 2021
Backport #24116 to 20.8: Fix bug for explain pipeline
f9ece02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kitaisreal kitaisreal kitaisreal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kitaisreal kitaisreal

Labels

no-docs-needed pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hexiaoting @qoega @kitaisreal @robot-clickhouse