Conversation
|
I'm not sure about installation. Maybe it would be better to create a separate PR. |
|
Target: replace zookeeper in integration tests. (Without great efforts) |
|
Only six tests failed! Nice! And most of them because of incorrect IP protocol (need to make keeper config pluggable |
Cool! BTW it's interestion if it will also work for Kafka (integration tests setup separate zookeeper for Kafka). |
|
It will work with Kafka unless it is using ACL. |
|
|
|
|
|
Hmmm, even no session expired messages: |
|
There are no strange errors in the clickhouse-server's log https://gist.github.com/alesapin/20ca2b5f492d8c3702e82c10bf0d6b4b. So the test was just too slow? I'll make it more lightweight. |
|
Seems like #23997 didn't completely helped. |
programs/keeper/Keeper.cpp
Outdated
| else if (config().has("keeper_server.snapshot_storage_path")) | ||
| path = config().getString("keeper_server.snapshot_storage_path"); | ||
| else | ||
| path = std::filesystem::path{DBMS_DEFAULT_PATH} / "coordination/logs"; |
There was a problem hiding this comment.
Is it still possible to use embedded keeper in clickhouse-server? Do we need some protection from running multiple keepers (for example, embedded and standalone ones) in one directory?
There was a problem hiding this comment.
It just shouldn't start because of the same ports or the same PID files. But it's always possible to turn your data into the garbage. It's also possible with clickhouse-server. Maybe it would be better to have a separate path, I'll add KEEPER_DEFAULT_PATH.
|
|
|
I'm curious why there are so many likes?) We still have to implement data import from ZooKeeper. But it should be OK for fresh installations if you don't use zookeeper auth (quite weird thing). |
Not sure about everyone else, but I've been watching your progress closely since #15090 and am really looking forward to using this :) |
|
All failures are not related to changes |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add standalone
clickhouse-keepersymlink to the mainclickhousebinary. Now it's possible to run coordination without the main clickhouse server.