Add missing table schema for postgres dictionary#23980
Merged
alesapin merged 1 commit intoClickHouse:masterfrom May 12, 2021
Merged
Add missing table schema for postgres dictionary#23980alesapin merged 1 commit intoClickHouse:masterfrom
alesapin merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
kssenii
added
the
pr-must-backport
alesapin
approved these changes
May 12, 2021
Member
alesapin
left a comment
alesapin
left a comment
There was a problem hiding this comment.
Almost the same code as here https://github.com/ClickHouse/ClickHouse/blob/master/src/Dictionaries/XDBCDictionarySource.cpp#L76-L83, but it's OK. Don't need to generalize it.
Member
|
|
Member
|
Hmmm, PVS Studio tries to say something to us.... but I cannot figure out what exactly... |
Member
|
No related failures in integration tests. |
This was referenced May 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 13, 2021
kssenii
added a commit
that referenced
this pull request
May 14, 2021
Backport #23980 to 21.3: Add missing table schema for postgres dictionary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support specifying table schema for postgresql dictionary source. Closes #23958.