Preserve errors for INSERT into Distributed#23744
Merged
kitaisreal merged 3 commits intoClickHouse:masterfrom Apr 29, 2021
Merged
Preserve errors for INSERT into Distributed#23744kitaisreal merged 3 commits intoClickHouse:masterfrom
kitaisreal merged 3 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
kitaisreal
suggested changes
Apr 28, 2021
kitaisreal
approved these changes
Apr 28, 2021
Before this patch (and after ClickHouse#22208) the INSERT may fail with "Cannot schedule a task" because the pool in DistributedBlockOutputStream already throws exception and simply fail in writeSuffix().
azat
force-pushed
the
dist-INSERT-preserve-error
branch
from
2eedce8 to
73ab415
Compare
kitaisreal
approved these changes
Apr 28, 2021
Member
Author
Known flaky tests
Any clue? |
Member
Author
|
Let's try this #23750 |
Contributor
|
@azat synchronisation check is our issue in master. |
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 29, 2021
kitaisreal
added a commit
that referenced
this pull request
Apr 29, 2021
Backport #23744 to 21.5: Preserve errors for INSERT into Distributed
kitaisreal
added a commit
that referenced
this pull request
Apr 30, 2021
Backport #23744 to 21.4: Preserve errors for INSERT into Distributed
kitaisreal
added a commit
that referenced
this pull request
Apr 30, 2021
Backport #23744 to 21.3: Preserve errors for INSERT into Distributed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid possible "Cannot schedule a task" error (in case some exception had been occurred) on INSERT into Distributed
Detailed description / Documentation draft:
Before this patch (and after #22208) the INSERT may fail with "Cannot
schedule a task" because the pool in DistributedBlockOutputStream
already throws exception and simply fail in writeSuffix().
NOTE: that this is kind of minor issue so maybe it does not worth it marking as bugfix to avoid backports