Segfault on INSERT in HTTPHandler #23643
Merged
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom Apr 27, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
nikitamikhaylov
force-pushed
the
pp-segfault
branch
from
271cd0a to
9a70136
Compare
abyss7
approved these changes
Apr 26, 2021
This was referenced Apr 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 27, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Apr 28, 2021
Backport #23643 to 21.4: Segfault on INSERT in HTTPHandler
alexey-milovidov
added a commit
that referenced
this pull request
Apr 28, 2021
Backport #23643 to 21.5: Segfault on INSERT in HTTPHandler
Contributor
|
Was it backported to 21.3? Why backport PR is still opened? |
Contributor
Because it has conflicts, which no one resolved. |
Contributor
@nikitamikhaylov can you try to finish that / resolve conflicts? |
nikitamikhaylov
added a commit
that referenced
this pull request
May 24, 2021
…651538765bc6c3ae95bf9ef1217da Cherry pick #23643 to 21.3: Segfault on INSERT in HTTPHandler
robot-clickhouse
pushed a commit
that referenced
this pull request
May 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 27, 2021
nikitamikhaylov
added a commit
that referenced
this pull request
Jun 1, 2021
Backport #23643 to 21.3: Segfault on INSERT in HTTPHandler
nikitamikhaylov
added a commit
that referenced
this pull request
Jun 1, 2021
Backport #23643 to 20.8: Segfault on INSERT in HTTPHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed server fault when inserting data through HTTP caused an exception. This fixes #23512
Detailed description / Documentation draft:
Parsing started before the full pipeline is constructed and the table existence is checked.