Fix segfault in TSan on _exit#23616
Merged
alexey-milovidov merged 2 commits intomasterfrom Apr 25, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
Member
Author
|
@Mergifyio update |
Contributor
|
Command
|
Member
Author
|
Stress tests ok. |
alexey-milovidov
added
the
pr-must-backport
Member
Author
|
Need backport to 21.5. |
This was referenced May 20, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 20, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 20, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 20, 2021
alexey-milovidov
added a commit
that referenced
this pull request
May 21, 2021
Backport #23616 to 21.5: Fix segfault in TSan on _exit
alexey-milovidov
added a commit
that referenced
this pull request
May 21, 2021
Backport #23616 to 21.4: Fix segfault in TSan on _exit
alexey-milovidov
added a commit
that referenced
this pull request
May 21, 2021
Backport #23616 to 21.3: Fix segfault in TSan on _exit
robot-clickhouse
pushed a commit
that referenced
this pull request
May 28, 2021
alexey-milovidov
added a commit
that referenced
this pull request
May 31, 2021
Backport #23616 to 20.8: Fix segfault in TSan on _exit
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Nov 7, 2022
Because safeExit() does not includes header with defines, it does not know about THREAD_SANITIZER. And it also fixes Azure blob storage, actually everything is fine with the sdk itself, the problem is only in TSan that intercepts _exit() and report leak, even thoug that tread will be joined later. Refs: ClickHouse#23056 (ClickHouse#23616) Fixes: ClickHouse#38474 Closes: ClickHouse#42640 Fixes: ClickHouse#42638 Fixes: ClickHouse#34988 Cc: @alexey-milovidov, @tavplubix Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
This closes #23056