Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
tavplubix
reviewed
Apr 20, 2021
| const auto & cur = header.getByPosition(i).column; | ||
|
|
||
| /// Only remove const from common header if it is not const for current pipe. | ||
| if (cur && common && !isColumnConst(*cur)) |
Member
Author
There was a problem hiding this comment.
Yes, that's the point.
This code removes const from common header if in different pipes const is different for the same columns.
Member
There was a problem hiding this comment.
So is is possible, that column in common header is const, columns in all pipes are const, but const columns contain different values?
Member
Author
There was a problem hiding this comment.
For pipe this is not possible and separately checked.
For query plan, this is possible, and different constants are separately materialized.
Add comment.
tavplubix
approved these changes
Apr 20, 2021
This was referenced Apr 21, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible
Block structure mismatcherror for queries withUNIONwhich could possibly happen after filter-push-down optimization. Fixes #23029