Revert "Move conditions from JOIN ON to WHERE"#22753
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
|
Could it be backported to at least an LTS version (21.3.x)? |
vdimir
added a commit
to vdimir/ClickHouse
that referenced
this pull request
Jul 2, 2021
…joinon (cherry picked from commit 8c7ffda)
Member
Author
|
@Flamefork sorry, we decided not to backport it, because it will break queries that use this feature and changing in with minor version doesn't look good. |
|
I see, that's totally reasonable. Anyway, thanks for the effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Moving conditions from
JOIN ONinto outerWHEREworks in restricted number of cases (ALL INNER). We need mo sophisticated solution to handle different types of expressions in ON section like #21868Alternative to this PR fix is #22745