Allow columns with unknown table in CollectJoinOnKeysMatcher#22745
Closed
vdimir wants to merge 1 commit intoClickHouse:masterfrom
Closed
Allow columns with unknown table in CollectJoinOnKeysMatcher#22745vdimir wants to merge 1 commit intoClickHouse:masterfrom
vdimir wants to merge 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
vdimir
force-pushed
the
fix-join-arrayjoin-unknown-col
branch
from
856c372 to
351a48d
Compare
Member
Author
|
We will allow more cases in Previously it was forbidden in #15162, this PR relax some rules. E.g. |
vdimir
force-pushed
the
fix-join-arrayjoin-unknown-col
branch
from
351a48d to
c097803
Compare
Member
Author
|
Decided to merge revert #22753 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix unknown column error for
ARRAY JOINwithJOIN ON, close #22399.Alternatively we can Revert "Move conditions from JOIN ON to WHERE", see #22753