Skip to content

Fix potential segfault on Keeper startup#22743

Merged
alesapin merged 3 commits intomasterfrom
fix_potential_segfault_on_startup
Apr 7, 2021
Merged

Fix potential segfault on Keeper startup#22743
alesapin merged 3 commits intomasterfrom
fix_potential_segfault_on_startup

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Apr 7, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

eBay/NuRaft#194

@alesapin alesapin added the jepsen-test Need to test this PR with jepsen tests label Apr 7, 2021
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 7, 2021
@alexey-milovidov alexey-milovidov self-assigned this Apr 7, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Apr 7, 2021

Yarr

WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=52727)                                                                                                                                                                
  Cycle in lock order graph: M3412 (0x7b4400002c68) => M3497 (0x7b6800000938) => M3412                                                                                                                                                         

@alesapin alesapin added the do not test disable testing on pull request label Apr 7, 2021
@alesapin alesapin removed the do not test disable testing on pull request label Apr 7, 2021
@robot-ch-test-poll2 robot-ch-test-poll2 added the submodule changed At least one submodule changed in this PR. label Apr 7, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Apr 7, 2021

Now fix is more correct, but required changes in NuRaft :(

@alesapin alesapin merged commit c85a60d into master Apr 7, 2021
@alesapin alesapin deleted the fix_potential_segfault_on_startup branch April 7, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jepsen-test Need to test this PR with jepsen tests pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants