Fix flaky test 00816_long_concurrent_alter_column#22628
Merged
alexey-milovidov merged 1 commit intomasterfrom Apr 5, 2021
Merged
Fix flaky test 00816_long_concurrent_alter_column#22628alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
tavplubix
approved these changes
Apr 4, 2021
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
It is possible that at the moment of time when
timeoutis finished, some subshells are still active, but queries are not in the processlist, as they will be received by server a moment later. For this reason, checking the absence of queries in SHOW PROCESSLIST just once is not enough to wait for finish.