Skip to content

Follow up to #19516#22323

Merged
alexey-milovidov merged 9 commits intoClickHouse:masterfrom
abyss7:poco-http2
Apr 2, 2021
Merged

Follow up to #19516#22323
alexey-milovidov merged 9 commits intoClickHouse:masterfrom
abyss7:poco-http2

Conversation

@abyss7
Copy link
Copy Markdown
Contributor

@abyss7 abyss7 commented Mar 29, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Other

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix some points from this comment #19516 (comment)

@robot-clickhouse robot-clickhouse added the pr-other Pull request with changes not fitting to other categories label Mar 29, 2021
@alexey-milovidov alexey-milovidov self-assigned this Mar 29, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

A test for max_uri_size needed.

@alexey-milovidov
Copy link
Copy Markdown
Member

Also please check other settings and places in code about uri vs. url. If we're already using url everywhere, maybe it's better to name the setting max_url_length even if it's more old fashioned.

@abyss7
Copy link
Copy Markdown
Contributor Author

abyss7 commented Mar 29, 2021

Also please check other settings and places in code about uri vs. url. If we're already using url everywhere, maybe it's better to name the setting max_url_length even if it's more old fashioned.

I found a sole setting with an 'url' in its name: M(URI, format_avro_schema_registry_url), also in code it's not that widely used either. I suggest to leave the name as it is.

@alexey-milovidov
Copy link
Copy Markdown
Member

Ok.

@alexey-milovidov
Copy link
Copy Markdown
Member

Stress test (thread) — Fatal message in clickhouse-server.log

OOM

@alexey-milovidov
Copy link
Copy Markdown
Member

Integration:

e = HTTPError('409 Client Error: Conflict for url: http+docker://localhost/v1.41/containers/5b28247074bad9b7697d6dc1e780be3645ad2b7a34f437196bc3e10293cc09fa/exec',)

    def create_api_error_from_http_exception(e):
        """
        Create a suitable APIError from requests.exceptions.HTTPError.
        """
        response = e.response
        try:
            explanation = response.json()['message']
        except ValueError:
            explanation = (response.content or '').strip()
        cls = APIError
        if response.status_code == 404:
            if explanation and ('No such image' in str(explanation) or
                                'not found: does not exist or no pull access'
                                in str(explanation) or
                                'repository does not exist' in str(explanation)):
                cls = ImageNotFound
            else:
                cls = NotFound
>       raise cls(e, response=response, explanation=explanation)
E       docker.errors.APIError: 409 Client Error for http+docker://localhost/v1.41/containers/5b28247074bad9b7697d6dc1e780be3645ad2b7a34f437196bc3e10293cc09fa/exec: Conflict ("Container 5b28247074bad9b7697d6dc1e780be3645ad2b7a34f437196bc3e10293cc09fa is not running")

No idea what does it mean.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Apr 2, 2021

Server failed to start with:

Caught exception while loading metadata: Code: 36, e.displayText() = DB::Exception: Dictionary (test_01676.dict) not found: While processing CAST(dictGet('test_01676.dict', 'value', x) AS y_tmp_alter17144938244732776432, 'UInt64') AS y: default expression and column type are incompatible.: Cannot attach table test_01676.table from metadata file /var/lib/clickhouse/store/060/0604aada-1fbb-4a1c-8325-99d4a6e56caf/table.sql from query ATTACH TABLE test_01676.table UUID '56e67de3-8f59-403c-baed-e7a44aef814a' (xUInt64,yUInt64 DEFAULT dictGet('test_01676.dict', 'value', x)) ENGINE = MergeTree ORDER BY tuple() SETTINGS index_granularity = 8192: while loading databasetest_01676 from path /var/lib/clickhouse/metadata/test_01676

@alexey-milovidov alexey-milovidov merged commit 9f5cd35 into ClickHouse:master Apr 2, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

@abyss7 Now the following remains:

  • get rid of ostream when writing result;
  • check if zero copy data reading is possible in HTTPChunkedReadBuffer.

@abyss7 abyss7 deleted the poco-http2 branch April 6, 2021 13:10
@gyuton
Copy link
Copy Markdown
Contributor

gyuton commented Apr 13, 2021

Internal documentation ticket: DOCSUP-8495.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-other Pull request with changes not fitting to other categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants