Cherry pick #22183 to 21.1: Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1#22293
Merged
Avogar merged 3 commits intobackport/21.1/22183from Apr 2, 2021
Conversation
…r_remote=1 In #21643 async_socket_for_remote=1 was fixed to avoid leaving the connection in the unsynchronised state. But one should not try to wait for the current packet in case of timeout because this will exceed the timeout. Anyway if the timeout is exceeded, then the connection will be shutdown (disconnected), so it will not left in an unsynchronised state.
…cel-on-timeout-fix Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1
robot-clickhouse
added
do not test
…ee6efd4c0c3b953224e50861eaf
Avogar
deleted the
cherrypick/21.1/6d60f2eb871beee6efd4c0c3b953224e50861eaf
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #22183
This pull-request is a first step of an automated backporting.
It contains changes like after calling a local command
git cherry-pick.If you intend to continue backporting this changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Also this pull-request will be merged automatically as it reaches the mergeable state, but you always can merge it manually.