Do not silently catch errors for writing to S3#22208
Merged
vdimir merged 4 commits intoClickHouse:masterfrom Apr 26, 2021
Merged
Do not silently catch errors for writing to S3#22208vdimir merged 4 commits intoClickHouse:masterfrom
vdimir merged 4 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
azat
force-pushed
the
s3-writer
branch
4 times, most recently
from
3c1293f to
479fa89
Compare
Member
Author
|
@vdimir can you take a look? |
vdimir
reviewed
Apr 16, 2021
azat
force-pushed
the
s3-writer
branch
2 times, most recently
from
7d568cb to
4cefa4e
Compare
That may lead to uncaught exception [1]. [1]: ClickHouse#21624 (comment) v0: New method BlockOutputStream::finalize() -- bad (forgot some places and superfluous) v2: Flush BlockOutputStream in QueryStatus::releaseQueryStreams() Safer query termination (report some uncaugh errors to user) v3: Flush BlockOutputStream from TCPHandler only Other places uses different executeQuery() implementation v4: Do not call writeSuffix() twice
vdimir
approved these changes
Apr 26, 2021
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Apr 28, 2021
Before this patch (and after ClickHouse#22208) the INSERT may fail with "Cannot schedule a task" because the pool in DistributedBlockOutputStream already throws exception and simply fail in writeSuffix().
kitaisreal
pushed a commit
that referenced
this pull request
Apr 29, 2021
Before this patch (and after #22208) the INSERT may fail with "Cannot schedule a task" because the pool in DistributedBlockOutputStream already throws exception and simply fail in writeSuffix().
kitaisreal
pushed a commit
that referenced
this pull request
Apr 29, 2021
Before this patch (and after #22208) the INSERT may fail with "Cannot schedule a task" because the pool in DistributedBlockOutputStream already throws exception and simply fail in writeSuffix().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not silently catch errors for writing to S3
Cc: @vdimir
Cc: @excitoon
Refs: #22110