Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1#22183
Merged
Avogar merged 1 commit intoClickHouse:masterfrom Mar 29, 2021
Conversation
robot-clickhouse
added
the
pr-bugfix
Avogar
approved these changes
Mar 26, 2021
…r_remote=1 In ClickHouse#21643 async_socket_for_remote=1 was fixed to avoid leaving the connection in the unsynchronised state. But one should not try to wait for the current packet in case of timeout because this will exceed the timeout. Anyway if the timeout is exceeded, then the connection will be shutdown (disconnected), so it will not left in an unsynchronised state.
azat
force-pushed
the
async_socket_for_remote-query-cancel-on-timeout-fix
branch
from
1663b0e to
82c79fe
Compare
Member
Author
|
This was referenced Mar 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 29, 2021
…sts=0 and async_socket_for_remote=1
alexey-milovidov
added a commit
that referenced
this pull request
Apr 1, 2021
Backport #22183 to 21.3: Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 2, 2021
…sts=0 and async_socket_for_remote=1
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 2, 2021
…sts=0 and async_socket_for_remote=1
alexey-milovidov
added a commit
that referenced
this pull request
Apr 3, 2021
Backport #22183 to 21.2: Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1
Avogar
added a commit
that referenced
this pull request
Apr 3, 2021
Backport #22183 to 21.1: Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix query cancellation with
use_hedged_requests=0andasync_socket_for_remote=1Detailed description / Documentation draft:
In #21643 async_socket_for_remote=1 was fixed to avoid leaving the
connection in the unsynchronised state.
But one should not try to wait for the current packet in case of timeout
because this will exceed the timeout.
Anyway if the timeout is exceeded, then the connection will be shutdown
(disconnected), so it will not left in an unsynchronised state.