Skip to content

Fix sleep_in_send_tables_status_ms/sleep_in_send_data_ms in integration tests#22151

Merged
Avogar merged 2 commits intoClickHouse:masterfrom
azat:tests-sleep_in_send_ms
Mar 26, 2021
Merged

Fix sleep_in_send_tables_status_ms/sleep_in_send_data_ms in integration tests#22151
Avogar merged 2 commits intoClickHouse:masterfrom
azat:tests-sleep_in_send_ms

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Mar 26, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #21998
Cc: @Avogar

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 26, 2021
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 26, 2021

By the way, parsing flaky/error looks wrong

@azat azat force-pushed the tests-sleep_in_send_ms branch 2 times, most recently from 2f419c9 to c36f147 Compare March 26, 2021 08:08
@Avogar Avogar self-assigned this Mar 26, 2021
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 26, 2021

Integration tests flaky check (asan) — Flaky tests found: skipped: 0, passed: 1, fail: 1, error: 2, flaky: 0

Test failure is related, will fix separately

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Mar 26, 2021

@azat do you know the problem? For unknown reason in case when async_socket_for_remote = 1 and use_hedged_requests = 0 receive timeout doesn't work. When I created PR with test_secure_socket everything was ok. I am trying to figure out what the problem is.

@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 26, 2021

@azat do you know the problem?

Yep, will send a patch later

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Mar 26, 2021

If I'm right, the problem appeared in #21643
Will wait for the patch, thanks!

@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 26, 2021

If I'm right, the problem appeared in #21643

You are right.

Will wait for the patch, thanks!

#22183 - (submitted separately for backporting)

I can rebase it once this PR will be merged

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Mar 26, 2021

Let's merge it then.

@Avogar Avogar merged commit c86202d into ClickHouse:master Mar 26, 2021
@azat azat deleted the tests-sleep_in_send_ms branch March 26, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants