Fix docker entrypoint in case http_port is not in the config#22132
Merged
alesapin merged 1 commit intoClickHouse:masterfrom Mar 29, 2021
Merged
Fix docker entrypoint in case http_port is not in the config#22132alesapin merged 1 commit intoClickHouse:masterfrom
alesapin merged 1 commit intoClickHouse:masterfrom
Conversation
`http_port` can be removed from the configuration when serving HTTP is not desired. When it is not present, `extract-from-config` will fail, which will prevent the server from starting. Only fetch it when it is required for database initialization.
robot-clickhouse
added
the
pr-bugfix
Contributor
|
Vs #22102 ? |
Contributor
Author
Seems I went straight for the fix instead of checking the bug reports and open PRs 🙈 . If the other PR is preferred, I can trim it down to only solve the problem with missing |
devwout
force-pushed
the
fix-docker-entrypoint
branch
from
10c21e2 to
6fe2649
Compare
devwout
changed the title
Contributor
Author
|
Reduced the PR to only contain the fix for config without |
alesapin
approved these changes
Mar 29, 2021
Member
alesapin
left a comment
alesapin
left a comment
There was a problem hiding this comment.
Ok, this fix doesn't change a lot but also doesn't break anything.
Member
|
Tests not required. |
This was referenced Mar 29, 2021
Closed
Closed
Merged
Closed
alesapin
added a commit
that referenced
this pull request
Mar 30, 2021
Backport #22132 to 21.2: Fix docker entrypoint in case http_port is not in the config
alesapin
added a commit
that referenced
this pull request
Mar 30, 2021
Backport #22132 to 21.3: Fix docker entrypoint in case http_port is not in the config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix docker entrypoint in case
http_portis not in the config....
Detailed description / Documentation draft:
...
By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.
Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/