Better tests for finalize in nested writers#22110
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
|
This errors shall be fixed after rebase. @azat I agree that some work was done to make |
Agree, but what will be if someone will forget to call it? In my opinion it is better to terminate abnormally then silently ignore write failures. |
|
@azat May be some common runtime check which will be turned on in Debug and throw
exception if at moment of destruction there was written some data but not
finalized?
…On Tue, Mar 30, 2021, 8:39 AM Azat Khuzhin ***@***.***> wrote:
User must call finalize() after they write somthing and the reason we
introduce implicit finalization was another bug when finalize() was missed
in compression streams.
Agree, but what will be if someone will forget to call it?
In my opinion it is better to terminate abnormally then silently ignore
write failures.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSB4J434Q6ZJOAIZKDX3TGFPZVANCNFSM4ZYZIZAA>
.
|
|
This PR is ready for review, failed tests are unrelated. |
6 participants
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Additional tests for #21305