Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels#22109
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Mar 29, 2021
Merged
Conversation
…ernels async_socket_for_remote/use_hedged_requests uses nested epolls, which may not be reliable in 5.5+ [1], but it has been fixed in shortly in 5.7+ [2] or 5.6.13+. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=339ddb53d373 [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c54a6a44bf3
nikitamikhaylov
approved these changes
Mar 26, 2021
This was referenced Mar 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 29, 2021
…equests for buggy linux kernels
alexey-milovidov
added a commit
that referenced
this pull request
Mar 30, 2021
Backport #22109 to 21.3: Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 30, 2021
…equests for buggy linux kernels
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 30, 2021
…equests for buggy linux kernels
Closed
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 14, 2021
The ClickHouse#22109 adds the check but at compilation time, which is pointless, move the check into runtime. Remember nested epoll is required for async_socket_for_remote/use_hedged_requests, otherwise remote queries may stuck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disable
async_socket_for_remote/use_hedged_requestsfor buggy linux kernelsDetailed description / Documentation draft:
async_socket_for_remote/use_hedged_requests uses nested epolls, which
may not be reliable in 5.5+ 1, but it has been fixed in shortly in 5.7+ 2 or 5.6.13+.
P.S. marked as Bug fix, but not sure about this
Details
It is possible to lock the pipeline, It is not that easy to reproduce, but it is pretty "stable" reproduced with the following benchmark command, using linux 5.5:
Note, that use_hedged_requests and async_socket_for_remote is both
required for reproducing.
Pipeline:
Threads stack traces:
And to be presice the PipelineExecutor is waiting here 1:
State of PipelineExecutor at this time:
Cc: @KochetovNicolai
Cc: @Avogar