Skip to content

CollapsingSortedAlgorithm should not return more than index_granularity rows#21976

Merged
alesapin merged 8 commits intomasterfrom
try-fix-excessive-rows-for-collapsing-merge
Apr 1, 2021
Merged

CollapsingSortedAlgorithm should not return more than index_granularity rows#21976
alesapin merged 8 commits intomasterfrom
try-fix-excessive-rows-for-collapsing-merge

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Mar 22, 2021

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
In rare case, merge for CollapsingMergeTree may create granule with index_granularity + 1 rows. Because of this, internal check, added in #18928 (affects 21.2 and 21.3), may fail with error Incomplete granules are not allowed while blocks are granules size. This error did not allow parts to merge.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 22, 2021
@alexey-milovidov alexey-milovidov changed the title CollapsingSortedAlgorithm should not return more then index_granularity rows CollapsingSortedAlgorithm should not return more than index_granularity rows Mar 22, 2021
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alesapin alesapin marked this pull request as ready for review March 23, 2021 07:59
@robot-clickhouse robot-clickhouse added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Mar 23, 2021
@alesapin alesapin merged commit 85fbb7e into master Apr 1, 2021
@alesapin alesapin deleted the try-fix-excessive-rows-for-collapsing-merge branch April 1, 2021 13:20
robot-clickhouse pushed a commit that referenced this pull request Apr 1, 2021
robot-clickhouse pushed a commit that referenced this pull request Apr 1, 2021
robot-clickhouse pushed a commit that referenced this pull request Apr 1, 2021
robot-clickhouse pushed a commit that referenced this pull request Apr 1, 2021
robot-clickhouse pushed a commit that referenced this pull request Apr 1, 2021
alexey-milovidov added a commit that referenced this pull request Apr 2, 2021
Backport #21976 to 21.3: CollapsingSortedAlgorithm should not return more than index_granularity rows
alesapin added a commit that referenced this pull request Apr 2, 2021
Backport #21976 to 21.2: CollapsingSortedAlgorithm should not return more than index_granularity rows
alesapin added a commit that referenced this pull request Apr 2, 2021
Backport #21976 to 21.1: CollapsingSortedAlgorithm should not return more than index_granularity rows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants