Better error handling and logging in WriteBufferFromS3#21836
Merged
Avogar merged 5 commits intoClickHouse:masterfrom Mar 24, 2021
Merged
Better error handling and logging in WriteBufferFromS3#21836Avogar merged 5 commits intoClickHouse:masterfrom
Avogar merged 5 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
Avogar
approved these changes
Mar 22, 2021
Member
|
Let's wait for the tests and merge, I just want all the integration tests to run without a timeout) |
Member
|
@Jokser there are some conflicts appeared, can you look at it? |
…ter-error-handling # Conflicts: # src/IO/WriteBufferFromS3.cpp
…kser/ClickHouse into write-buffer-s3-better-error-handling
Contributor
Author
|
@Avogar Conflicts have resolved. Could you please merge the change? |
This was referenced Mar 24, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 26, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Apr 3, 2021
Backport #21836 to 21.3: Better error handling and logging in WriteBufferFromS3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Better error handling and logging in WriteBufferFromS3.
Detailed description / Documentation draft:
Currently, 'temporary_buffer' used in WriteBufferFromS3 may silently lose data if there is insufficient memory in CH process. This change improves error handling and adds more logging in WriteBufferFromS3.