Skip to content

Fix arena data race in two level merge#21818

Merged
CurtizJ merged 1 commit intoClickHouse:masterfrom
amosbird:datarace2
Mar 18, 2021
Merged

Fix arena data race in two level merge#21818
CurtizJ merged 1 commit intoClickHouse:masterfrom
amosbird:datarace2

Conversation

@amosbird
Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix possible crashes in aggregate functions with combinator Distinct, while using two-level aggregation. This is a follow-up fix of #18365 . Can only reproduced in production env. No test case available yet. cc @CurtizJ

Detailed description / Documentation draft:

.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Mar 17, 2021
@CurtizJ CurtizJ self-assigned this Mar 17, 2021
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CurtizJ CurtizJ merged commit 33aefa8 into ClickHouse:master Mar 18, 2021
alexey-milovidov added a commit that referenced this pull request Mar 19, 2021
Backport #21818 to 21.3: Fix arena data race in two level merge
CurtizJ added a commit that referenced this pull request Mar 22, 2021
Backport #21818 to 20.12: Fix arena data race in two level merge
CurtizJ added a commit that referenced this pull request Mar 22, 2021
Backport #21818 to 21.1: Fix arena data race in two level merge
CurtizJ added a commit that referenced this pull request Mar 22, 2021
Backport #21818 to 21.2: Fix arena data race in two level merge
kitaisreal added a commit that referenced this pull request Apr 25, 2021
Backport #21818 to 20.8: Fix arena data race in two level merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants