Fix conversions for fields in function 'arrayElement' for type Map#21699
Merged
CurtizJ merged 3 commits intoClickHouse:masterfrom Mar 23, 2021
Merged
Fix conversions for fields in function 'arrayElement' for type Map#21699CurtizJ merged 3 commits intoClickHouse:masterfrom
CurtizJ merged 3 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
CurtizJ
force-pushed
the
fix-map-field-conversion
branch
from
0e65393 to
68b3cbb
Compare
vitlibar
reviewed
Mar 15, 2021
|
|
||
| SELECT m[-1], m[0], m[toInt128(1234567898765432123456789)], m[toInt128(-1234567898765432123456789)] FROM table_map_with_key_integer; | ||
| SELECT m[toUInt64(0)], m[toInt64(0)], m[toUInt8(0)], m[toUInt16(0)] FROM table_map_with_key_integer; | ||
|
|
Member
There was a problem hiding this comment.
It seems line 70 should be
SELECT 'Map(Int128, String)';
instead of
SELECT 'Map(Int128, Int32)';
Could you fix that?
vitlibar
reviewed
Mar 15, 2021
src/Functions/array/arrayElement.cpp
Outdated
| return false; | ||
|
|
||
| bool is_integer_field = Field::dispatch([](const auto & value) | ||
| std::optional<DataType> index_value; |
Member
There was a problem hiding this comment.
index_as_integer seems to be more clear name
vitlibar
reviewed
Mar 15, 2021
src/Functions/array/arrayElement.cpp
Outdated
|
|
||
| bool is_integer_field = Field::dispatch([](const auto & value) | ||
| std::optional<DataType> index_value; | ||
| Field::dispatch([&index_value](const auto & value) |
vitlibar
approved these changes
Mar 15, 2021
Member
Author
Member
Author
|
Failed tests are not related. |
This was referenced Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix function
arrayElementwith typeMapfor constant integer arguments.