Skip to content

Backport #21334 to 21.1: Fix alter modify query for partition key and other metadata fields#21549

Merged
alesapin merged 1 commit into21.1from
backport/21.1/21334
Mar 10, 2021
Merged

Backport #21334 to 21.1: Fix alter modify query for partition key and other metadata fields#21549
alesapin merged 1 commit into21.1from
backport/21.1/21334

Conversation

@robot-clickhouse
Copy link
Copy Markdown
Member

@robot-clickhouse robot-clickhouse commented Mar 9, 2021

Original pull-request #21334
Cherry-pick pull-request #21400

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

@robot-clickhouse robot-clickhouse added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label Mar 9, 2021
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Mar 10, 2021

test_replace_partition/test.py::test_replace_after_replace_failover not related to changes.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Mar 10, 2021

No idea what's wrong with replace partition test:

node5/logs/clickhouse-server.log
224:2021.03.09 17:58:50.637165 [ 11 ] {a96a1319-67e5-4b75-bad2-227e7803bb90} <Debug> default.test_table (4f0c7ad5-9a5e-4f77-bb62-1ce4a0a0dc5c): Cloning part /var/lib/clickhouse/store/1e0/1e02db04-68ef-4c80-b2a6-552070f088a9/20170616_20170616_1_1_0/ to /var/lib/clickhouse/store/4f0/4f0c7ad5-9a5e-4f77-bb62-1ce4a0a0dc5c/tmp_replace_from_20170616_20170616_2_2_0
227:2021.03.09 17:58:50.640852 [ 11 ] {a96a1319-67e5-4b75-bad2-227e7803bb90} <Trace> default.test_table (4f0c7ad5-9a5e-4f77-bb62-1ce4a0a0dc5c): Renaming temporary part tmp_replace_from_20170616_20170616_2_2_0 to 20170616_20170616_2_2_0.
249:2021.03.09 17:58:50.844570 [ 11 ] {23d68a20-e40b-40dd-9ce1-3834e084f299} <Trace> default.test_table (4f0c7ad5-9a5e-4f77-bb62-1ce4a0a0dc5c) (SelectExecutor): Not using primary index on part 20170616_20170616_2_2_0
251:2021.03.09 17:58:50.845173 [ 11 ] {23d68a20-e40b-40dd-9ce1-3834e084f299} <Trace> MergeTreeSelectProcessor: Reading 1 ranges from part 20170616_20170616_2_2_0, approx. 1 rows starting from 0
272:2021.03.09 17:58:51.260786 [ 31 ] {} <Debug> default.test_table (4f0c7ad5-9a5e-4f77-bb62-1ce4a0a0dc5c): There is no part 20170616_20170616_2_2_0 in ZooKeeper, it was only in filesystem

node6/logs/clickhouse-server.log
196:2021.03.09 17:58:52.386291 [ 53 ] {} <Debug> default.test_table (2cec2784-47ec-4a6f-ae30-a2936d234324): Part 20170616_20170616_2_2_0 is not found on remote replicas
197:2021.03.09 17:58:52.387630 [ 53 ] {} <Debug> default.test_table (2cec2784-47ec-4a6f-ae30-a2936d234324): Parts covering 20170616_20170616_2_2_0 are not found on remote replicas
198:2021.03.09 17:58:52.388293 [ 53 ] {} <Information> default.test_table (2cec2784-47ec-4a6f-ae30-a2936d234324): DB::Exception: Not found part 20170616_20170616_2_2_0 (or part covering it) neither source table neither remote replicas

Looks flaky.

@alesapin alesapin merged commit 95bd1e1 into 21.1 Mar 10, 2021
@alesapin alesapin deleted the backport/21.1/21334 branch March 10, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alesapin alesapin

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robot-clickhouse @alesapin