Skip to content

Cleanup PODArray#21533

Merged
alexey-milovidov merged 7 commits intomasterfrom
podarray-cleanup
Mar 11, 2021
Merged

Cleanup PODArray#21533
alexey-milovidov merged 7 commits intomasterfrom
podarray-cleanup

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Mar 8, 2021

Changelog category (leave one):

  • Improvement

Changelog entry:
If PODArray was instantiated with element size that is neither a fraction or a multiple of 16, buffer overflow was possible. No bugs in current releases exist.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 8, 2021
@kitaisreal kitaisreal self-assigned this Mar 9, 2021
…iple-of-element-crash-fix

Pod array left pad not multiple of element crash fix
@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Mar 11, 2021
@alexey-milovidov alexey-milovidov added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-improvement Pull request with some product improvements labels Mar 11, 2021
@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Mar 11, 2021
@alexey-milovidov alexey-milovidov merged commit 6472460 into master Mar 11, 2021
@alexey-milovidov alexey-milovidov deleted the podarray-cleanup branch March 11, 2021 01:34
@alexey-milovidov
Copy link
Copy Markdown
Member Author

TODO fix arithmetic in swap method.

robot-clickhouse pushed a commit that referenced this pull request Apr 7, 2021
robot-clickhouse pushed a commit that referenced this pull request Apr 7, 2021
robot-clickhouse pushed a commit that referenced this pull request Apr 7, 2021
alexey-milovidov added a commit that referenced this pull request Apr 8, 2021
alexey-milovidov added a commit that referenced this pull request Apr 8, 2021
alexey-milovidov added a commit that referenced this pull request Apr 8, 2021
xinyiZzz added a commit to apache/doris that referenced this pull request Jun 3, 2024
1. Add PODArray ut
2. pick ClickHouse/ClickHouse#21533
3. pick ClickHouse/ClickHouse#21678
4. pick ClickHouse/ClickHouse#9498
5. pick ClickHouse/ClickHouse#7791
6. pick ClickHouse/ClickHouse#24271
7. if c_end_of_storage == null, allocated_bytes return 0.
8. Add some checks for DEBUG.
9. TODO: Adapt internal data structures to 512-bit era
ClickHouse/ClickHouse#42564
dataroaring pushed a commit to apache/doris that referenced this pull request Jun 4, 2024
1. Add PODArray ut
2. pick ClickHouse/ClickHouse#21533
3. pick ClickHouse/ClickHouse#21678
4. pick ClickHouse/ClickHouse#9498
5. pick ClickHouse/ClickHouse#7791
6. pick ClickHouse/ClickHouse#24271
7. if c_end_of_storage == null, allocated_bytes return 0.
8. Add some checks for DEBUG.
9. TODO: Adapt internal data structures to 512-bit era
ClickHouse/ClickHouse#42564
seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
1. Add PODArray ut
2. pick ClickHouse/ClickHouse#21533
3. pick ClickHouse/ClickHouse#21678
4. pick ClickHouse/ClickHouse#9498
5. pick ClickHouse/ClickHouse#7791
6. pick ClickHouse/ClickHouse#24271
7. if c_end_of_storage == null, allocated_bytes return 0.
8. Add some checks for DEBUG.
9. TODO: Adapt internal data structures to 512-bit era
ClickHouse/ClickHouse#42564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants