clickhouse-library-bridge for library dictionary source#21509
Merged
alesapin merged 61 commits intoClickHouse:masterfrom Apr 6, 2021
Merged
clickhouse-library-bridge for library dictionary source#21509alesapin merged 61 commits intoClickHouse:masterfrom
alesapin merged 61 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
doc-alert
pr-feature
robot-clickhouse
added
pr-improvement
alesapin
requested changes
Mar 22, 2021
Member
alesapin
left a comment
alesapin
left a comment
There was a problem hiding this comment.
Two main problems:
- We should pass IDs through the
POSTbody. - Seems like the attributes list is redundant and we don't need to serialize it.
alesapin
reviewed
Apr 5, 2021
programs/library-bridge/Handlers.h
Outdated
| void handleRequest(HTTPServerRequest & request, HTTPServerResponse & response) override; | ||
|
|
||
| private: | ||
| size_t keep_alive_timeout; |
Member
|
All failures not related to changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add clickhouse-library-bridge for library dictionary source. Closes #9502.