Skip to content

Fix alter modify query for partition key and other metadata fields#21334

Merged
alesapin merged 5 commits intomasterfrom
fix_alter_partition_key
Mar 3, 2021
Merged

Fix alter modify query for partition key and other metadata fields#21334
alesapin merged 5 commits intomasterfrom
fix_alter_partition_key

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Mar 1, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now ALTER MODIFY COLUMN queries will correctly affect changes in partition key, skip indices, TTLs, and so on. Fixes #13675.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Mar 1, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Mar 1, 2021

race :(

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Mar 2, 2021

Slightly more changes than I expected.

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Mar 3, 2021

test_distributed_ddl -- broken in master

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Mar 3, 2021

Performance -- no visible changes.

@alesapin alesapin merged commit 6b1005a into master Mar 3, 2021
@alesapin alesapin deleted the fix_alter_partition_key branch March 3, 2021 07:15
robot-clickhouse pushed a commit that referenced this pull request Mar 9, 2021
robot-clickhouse pushed a commit that referenced this pull request Mar 9, 2021
robot-clickhouse pushed a commit that referenced this pull request Mar 9, 2021
alesapin added a commit that referenced this pull request Mar 10, 2021
Backport #21334 to 21.1: Fix alter modify query for partition key and other metadata fields
alesapin added a commit that referenced this pull request Mar 10, 2021
Backport #21334 to 21.2: Fix alter modify query for partition key and other metadata fields
alesapin added a commit that referenced this pull request Mar 10, 2021
Backport #21334 to 20.12: Fix alter modify query for partition key and other metadata fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes of Enum in partition key is not FULLY applied until reattach

2 participants