Skip to content

Convert columns to nullable for totals in join#21248

Merged
vdimir merged 1 commit intoClickHouse:masterfrom
vdimir:fix-join-totals-nullable
Feb 27, 2021
Merged

Convert columns to nullable for totals in join#21248
vdimir merged 1 commit intoClickHouse:masterfrom
vdimir:fix-join-totals-nullable

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Feb 26, 2021 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug with join_use_nulls and joining TOTALS from subqueries. This closes #19362 and #21137.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Feb 26, 2021
@alexey-milovidov alexey-milovidov self-assigned this Feb 26, 2021
@azat
Copy link
Copy Markdown
Member

azat commented Feb 26, 2021

Looks like it also fixes #19362 ?

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Feb 27, 2021

Failed tests flapped over past 3 days in master too
test_materialize_mysql_database/test.py::test_select_without_columns_8_0[clickhouse_node1]
test_replace_partition/test.py::test_replace_after_replace_failover
test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed

┌─check_name──────────────────┬─test_name──────────────────────────────────────────────────────────────────────────────────┬────check_start_time─┬─test_status─┬─pull_request_number─┐
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_issue14202                                          │ 2021-02-26 22:41:34 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-26 15:52:13 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-26 10:01:09 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_replace_partition/test.py::test_replace_after_replace_failover                        │ 2021-02-26 08:04:10 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-26 08:04:10 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-26 08:03:25 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-26 05:31:17 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-25 17:40:47 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-25 17:25:35 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-25 17:25:04 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-25 11:26:35 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-25 08:19:06 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-25 04:06:51 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-24 15:42:00 │ FAIL        │                   0 │
│ Integration tests (thread)  │ test_storage_kafka/test.py::test_kafka_no_holes_when_write_suffix_failed                   │ 2021-02-24 14:28:44 │ FAIL        │                   0 │
│ Integration tests (release) │ test_materialize_mysql_database/test.py::test_select_without_columns_8_0[clickhouse_node1] │ 2021-02-24 12:24:48 │ FAIL        │                   0 │
└─────────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────┴─────────────────────┴─────────────┴─────────────────────┘

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Feb 27, 2021

Looks like it also fixes #19362 ?

Yes, same bug, thanks

@vdimir vdimir merged commit df728dc into ClickHouse:master Feb 27, 2021
@vdimir vdimir deleted the fix-join-totals-nullable branch February 27, 2021 08:31
@vdimir vdimir mentioned this pull request Feb 27, 2021
Closed
This was referenced Feb 27, 2021
Merged
Closed
Closed
Merged
Closed
robot-clickhouse pushed a commit that referenced this pull request Feb 27, 2021
Backport #21248 to 21.2: Convert columns to nullable for totals in join
0bedec6
@robot-clickhouse robot-clickhouse mentioned this pull request Feb 27, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Feb 27, 2021
Backport #21248 to 21.1: Convert columns to nullable for totals in join
f704ee8
@robot-clickhouse robot-clickhouse mentioned this pull request Feb 27, 2021
Merged
vdimir added a commit that referenced this pull request Feb 28, 2021
@vdimir
Merge pull request #21277 from ClickHouse/backport/21.1/21248
3ad6c7b 
Backport #21248 to 21.1: Convert columns to nullable for totals in join
vdimir added a commit that referenced this pull request Feb 28, 2021
@vdimir
Merge pull request #21276 from ClickHouse/backport/21.2/21248
fea4a0f 
Backport #21248 to 21.2: Convert columns to nullable for totals in join
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FULL OUTER JOIN: Logical error: 'Bad cast from type DB::ColumnString to DB::ColumnNullable'.

4 participants

@vdimir @azat @alexey-milovidov @robot-clickhouse