Restrict mutations for engines which doesn't support them#21183
Merged
Restrict mutations for engines which doesn't support them#21183
Conversation
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Feb 25, 2021
Member
|
Ok but it looks like a more high-level than just checking for nullptr. Maybe also add a low-level check just in case? |
alexey-milovidov
approved these changes
Feb 25, 2021
This was referenced Feb 26, 2021
Merged
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
alesapin
added a commit
that referenced
this pull request
Mar 3, 2021
Backport #21183 to 21.1: Restrict mutations for engines which doesn't support them
alesapin
added a commit
that referenced
this pull request
Mar 3, 2021
Backport #21183 to 21.2: Restrict mutations for engines which doesn't support them
alesapin
added a commit
that referenced
this pull request
Mar 3, 2021
…e5acb717d439310ad024b2a27201da Cherry pick #21183 to 20.12: Restrict mutations for engines which doesn't support them
alesapin
added a commit
that referenced
this pull request
Mar 3, 2021
…5acb717d439310ad024b2a27201da Cherry pick #21183 to 20.8: Restrict mutations for engines which doesn't support them
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 3, 2021
alesapin
added a commit
that referenced
this pull request
Mar 9, 2021
Backport #21183 to 20.12: Restrict mutations for engines which doesn't support them
alesapin
added a commit
that referenced
this pull request
Mar 9, 2021
Backport #21183 to 20.8: Restrict mutations for engines which doesn't support them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now mutations allowed only for table engines that support them (MergeTree family, Memory, MaterializedView). Other engines will report a more clear error. Fixes #21168.