rabbitmq: fix bug when late onReady callback causes duplicates#21138
Merged
kssenii merged 6 commits intoClickHouse:masterfrom Feb 26, 2021
Merged
rabbitmq: fix bug when late onReady callback causes duplicates#21138kssenii merged 6 commits intoClickHouse:masterfrom
kssenii merged 6 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
kitaisreal
approved these changes
Feb 24, 2021
Member
Author
|
|
This was referenced Feb 26, 2021
Merged
Merged
Closed
Merged
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
…k causes duplicates
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
…k causes duplicates
kitaisreal
added a commit
that referenced
this pull request
Feb 26, 2021
Backport #21138 to 21.1: rabbitmq: fix bug when late onReady callback causes duplicates
kitaisreal
added a commit
that referenced
this pull request
Feb 26, 2021
Backport #21138 to 20.12: rabbitmq: fix bug when late onReady callback causes duplicates
kitaisreal
added a commit
that referenced
this pull request
Feb 26, 2021
Backport #21138 to 21.2: rabbitmq: fix bug when late onReady callback causes duplicates
kssenii
added a commit
that referenced
this pull request
Feb 27, 2021
Backport #21138 to 20.11: rabbitmq: fix bug when late onReady callback causes duplicates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixes #21112. Fixed bug that could cause duplicates with insert query (if one of the callbacks came a little too late).
Detailed description:
If onReady() callback was a little late, publishing could happen before it was received, which caused duplicates because onAck/onNack handlers were not set up yet.