fix default_replica_path and default_replica_name values are useless …#21060
Merged
tavplubix merged 4 commits intoClickHouse:masterfrom Feb 26, 2021
Merged
Conversation
…on Replicated(*)MergeTree engine when the engine needs specify other parameters
robot-clickhouse
added
the
pr-bugfix
tavplubix
reviewed
Feb 22, 2021
Member
|
|
Contributor
Author
|
@tavplubix Functional stateless tests still failed, how can I fix it, thanks |
Member
|
Failed tests are known to be flaky, you don't have to do anything |
tavplubix
approved these changes
Feb 25, 2021
This was referenced Feb 26, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
…a_name values are useless …
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
…a_name values are useless …
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
…_name values are useless …
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
…_name values are useless …
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 26, 2021
…_name values are useless …
tavplubix
added a commit
that referenced
this pull request
Mar 3, 2021
Backport #21060 to 21.2: fix default_replica_path and default_replica_name values are useless …
tavplubix
added a commit
that referenced
this pull request
Mar 3, 2021
Backport #21060 to 21.1: fix default_replica_path and default_replica_name values are useless …
tavplubix
added a commit
that referenced
this pull request
Mar 3, 2021
Backport #21060 to 20.12: fix default_replica_path and default_replica_name values are useless …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on Replicated(*)MergeTree engine when the engine needs specify other parameters
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
fix default_replica_path and default_replica_name values are useless on Replicated(*)MergeTree engine when the engine needs specify other parameters
Detailed description / Documentation draft:
when create ReplicatedMergeTree table, the create clause is: "CREATE TABLE ...... ENGINE = ReplicatedMergeTree('/clickhouse/tables/{layer}-{shard}/table_name', '{replica}')" , you can omit arguments when specify default arguments(default_replica_path and default_replica_name) in the server configuration file. but, default arguments are invalid for other replicated engine which has other arguments, for example:ENGINE = ReplicatedReplacingMergeTree(ver) is illegal when we only specify ver.