Skip to content

Fix wrong formatting of overflowed DateTime64#21023

Merged
alexey-milovidov merged 2 commits intomasterfrom
fix-datetime64-formatting
Feb 22, 2021
Merged

Fix wrong formatting of overflowed DateTime64#21023
alexey-milovidov merged 2 commits intomasterfrom
fix-datetime64-formatting

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Out of bound memory access was possible when formatting specifically crafted out of range value of type DateTime64. This closes #20494. This closes #20543.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Feb 21, 2021
@kitaisreal kitaisreal self-assigned this Feb 21, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member Author

Requires #21022.

@alexey-milovidov alexey-milovidov force-pushed the fix-datetime64-formatting branch from e6d03f9 to adfac06 Compare February 21, 2021 18:01
@alexey-milovidov
Copy link
Copy Markdown
Member Author

Performance test Ok.

@alexey-milovidov alexey-milovidov merged commit c8da611 into master Feb 22, 2021
@alexey-milovidov alexey-milovidov deleted the fix-datetime64-formatting branch February 22, 2021 10:10
alexey-milovidov added a commit that referenced this pull request Feb 22, 2021
Backport #21023 to 21.2: Fix wrong formatting of overflowed DateTime64
@azat azat mentioned this pull request Feb 22, 2021
alexey-milovidov added a commit that referenced this pull request Feb 24, 2021
Backport #21023 to 21.1: Fix wrong formatting of overflowed DateTime64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DateTime64: out of bound array access, garbage results.

3 participants