Skip to content

Fix performance tests (by avoid sharing status file for right and left server)#21022

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:perf-fix
Feb 21, 2021
Merged

Fix performance tests (by avoid sharing status file for right and left server)#21022
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:perf-fix

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Feb 21, 2021

Since cp -al (hard links):

2021.02.21 01:09:09.991771 [ 243 ] {} <Information> StatusFile: Status file right/db/status already exists - unclean restart. Contents:
PID: 241
Started at: 2021-02-21 01:09:09
Revision: 54448

2021.02.21 01:09:09.992007 [ 243 ] {} <Error> Application: DB::Exception: Cannot lock file right/db/status. Another server instance in same directory is already running.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Cc: @akuzm

…ft server)

Since cp -al (hard links):

    2021.02.21 01:09:09.991771 [ 243 ] {} <Information> StatusFile: Status file right/db/status already exists - unclean restart. Contents:
    PID: 241
    Started at: 2021-02-21 01:09:09
    Revision: 54448

    2021.02.21 01:09:09.992007 [ 243 ] {} <Error> Application: DB::Exception: Cannot lock file right/db/status. Another server instance in same directory is already running.
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 21, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

Where it was broken?

@alexey-milovidov alexey-milovidov self-assigned this Feb 21, 2021
@azat
Copy link
Copy Markdown
Member Author

azat commented Feb 21, 2021

Where it was broken?

I did not look deeply, but I guess the reason is that status file was preserved after while killall clickhouse-server; do :; done right now, while before it was removed

@azat
Copy link
Copy Markdown
Member Author

azat commented Feb 21, 2021

Performance — 12 slower, 28 unstable

Passed

@alexey-milovidov alexey-milovidov merged commit daa50f5 into ClickHouse:master Feb 21, 2021
@azat azat changed the title Fix performance tests (by avoid sharding status file for right and left server) Fix performance tests (by avoid sharing status file for right and left server) Feb 21, 2021
@azat azat deleted the perf-fix branch February 21, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants