Do not start mutation for alters with wrong type conversion#21007
Merged
alesapin merged 1 commit intoClickHouse:masterfrom Feb 24, 2021
Merged
Do not start mutation for alters with wrong type conversion#21007alesapin merged 1 commit intoClickHouse:masterfrom
alesapin merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
CurtizJ
force-pushed
the
alter-bad-conversions
branch
from
5be350c to
48e1886
Compare
This was referenced Feb 24, 2021
Merged
Merged
Merged
Merged
alesapin
added a commit
that referenced
this pull request
Mar 1, 2021
Backport #21007 to 21.1: Do not start mutation for alters with wrong type conversion
alesapin
added a commit
that referenced
this pull request
Mar 1, 2021
Backport #21007 to 20.12: Do not start mutation for alters with wrong type conversion
alesapin
added a commit
that referenced
this pull request
Mar 1, 2021
Backport #21007 to 21.2: Do not start mutation for alters with wrong type conversion
alesapin
added a commit
that referenced
this pull request
Mar 1, 2021
Backport #21007 to 20.8: Do not start mutation for alters with wrong type conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed behaviour, when
ALTER MODIFY COLUMNcreated mutation, that will knowingly fail.Detailed description / Documentation draft:
This may lead to situation, when table metadata was changed to new and some parts were already written with new schema. So, we can't alter neither old parts to new schema, nor new parts to old schema. Only drop of column is possible in that case.