Skip to content

Better tests for protobuf format.#20968

Merged
vitlibar merged 1 commit intoClickHouse:masterfrom
vitlibar:protobuf-format-better-tests
Feb 24, 2021
Merged

Better tests for protobuf format.#20968
vitlibar merged 1 commit intoClickHouse:masterfrom
vitlibar:protobuf-format-better-tests

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Feb 19, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Not for changelog

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 19, 2021
@vitlibar vitlibar force-pushed the protobuf-format-better-tests branch from fcbccb0 to 2eecaee Compare February 20, 2021 20:13
@vitlibar vitlibar merged commit 92bf2cf into ClickHouse:master Feb 24, 2021
@vitlibar vitlibar deleted the protobuf-format-better-tests branch February 24, 2021 12:47
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Feb 24, 2021

@vitlibar It seems that after this PR the build of utils is broken:

cmake -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_BUILD_TYPE=Debug -DPARALLEL_LINK_JOBS=12 -DPARALLEL_COMPILE_JOBS=56 -G Ninja ../../ClickHouse/

ninja: error: '/home/jakalletti/ClickHouse/ClickHouse/tests/queries/0_stateless/00825_protobuf_format.proto', needed by 'utils/test-data-generator/00825_protobuf_format.pb.cc', missing and no known rule to make it

With option -DENABLE_UTILS=0 all works fine

@vitlibar
Copy link
Copy Markdown
Member Author

vitlibar commented Feb 24, 2021 •
edited
Loading

@vitlibar It seems that after this PR the build of utils is broken:

cmake -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_BUILD_TYPE=Debug -DPARALLEL_LINK_JOBS=12 -DPARALLEL_COMPILE_JOBS=56 -G Ninja ../../ClickHouse/

ninja: error: '/home/jakalletti/ClickHouse/ClickHouse/tests/queries/0_stateless/00825_protobuf_format.proto', needed by 'utils/test-data-generator/00825_protobuf_format.pb.cc', missing and no known rule to make it

With option -DENABLE_UTILS=0 all works fine

I forgot to delete this test-data-generator, I will fix that soon (#21148).

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Feb 24, 2021

ANTLR protobuf tests broken now? https://clickhouse-test-reports.s3.yandex.net/20968/2eecaee08dc1f52786527674d3e9263df846cdb1/functional_stateless_tests_(antlr_debug).html#fail1

@vitlibar
Copy link
Copy Markdown
Member Author

vitlibar commented Feb 24, 2021 •
edited
Loading

ANTLR protobuf tests broken now? https://clickhouse-test-reports.s3.yandex.net/20968/2eecaee08dc1f52786527674d3e9263df846cdb1/functional_stateless_tests_(antlr_debug).html#fail1

skip_list.json will be fixed in #21148

@alesapin alesapin mentioned this pull request Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vitlibar @nikitamikhaylov @alesapin @robot-clickhouse