Improve backtrace catching on server failures in CI for fast-tests#20864
Merged
alesapin merged 2 commits intoClickHouse:masterfrom Feb 20, 2021
Merged
Improve backtrace catching on server failures in CI for fast-tests#20864alesapin merged 2 commits intoClickHouse:masterfrom
alesapin merged 2 commits intoClickHouse:masterfrom
Conversation
Otherwise sometimes stacktraces may be lost [1]: [1]: https://clickhouse-test-reports.s3.yandex.net/20477/8ad20fcee5aaa642c2a2dd873d02103692d554f4/fast_test.html#fail1
robot-clickhouse
added
the
pr-not-for-changelog
Member
Author
Member
Author
|
Actually docker image was updated, but it seems that fast test check does not use per-PR docker images |
Member
Yes, you right. Fasttest doesn't use an updated image from PR. Two reasons:
|
Member
Author
@alesapin maybe you can update it manually? |
Member
Unfortunately, it's not easy to do. Let me add gdb in fasttest image latest version and after that, your script should work well. |
Member
|
Done, let's wait until it will be pushed ea27c3c. |
Member
Author
alesapin
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Follow-up-for: #20462 (initially this PR was included into #20462, but docker image for fasttest was never updated, so it was moved into separate PR in attempt to fix this layers caching issue)